Fixing bug in uxgrid index_search #2444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure shapes stay consistent for single-face queries, and adds a small safeguard against zero norms
VeckoTheGecko
approved these changes
Jan 6, 2026
Contributor
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Looks good - just a clarifying comment below. I think it would be good to merge to enable #2443 if there's nothing more pending for this PR
| if np.any(ei): | ||
| indices = self.unravel_index(ei) | ||
| fi = indices.get("FACE") | ||
| is_in_cell, coords = uxgrid_point_in_cell(self.uxgrid, y, x, fi, fi) |
Contributor
There was a problem hiding this comment.
Just curious about this line change here - was the wrong object being passed before?
Member
Author
There was a problem hiding this comment.
Yes, this was indeed the wrong object being passed before. And our tests not picking it up...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure shapes stay consistent for single-face queries, and adds a small safeguard against zero norms